[CCI] Fix bottom notification bar width #3804
Conversation
SergeyMyssak
force-pushed
the
3336-Fix-bottom-notification-bar-width
branch
from
c1b3700
to
006cc46
Compare
|
@SergeyMyssak Thanks for looking at this. My main concern with this PR is that it is a fixed width that we are applying to mask this behaviour. What we want is this:
also, can we use the relative position of the bottom bar with respect to the flyout to auto adjust the width, instead of relying on a fixed width solution? |
@SergeyMyssak Do you mind opening an issue in OUI to remove those? |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3804 +/- ##
==========================================
- Coverage 66.44% 66.43% -0.01%
==========================================
Files 3229 3229
Lines 62068 62068
Branches 9599 9599
==========================================
- Hits 41238 41234 -4
- Misses 18527 18530 +3
- Partials 2303 2304 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
SergeyMyssak
force-pushed
the
3336-Fix-bottom-notification-bar-width
branch
from
006cc46
to
fd09fb1
Compare
|
@SergeyMyssak I'm marking this as a draft for now - we can revisit after getting the OUI changes merged first. |
Co-authored-by: Andrey Myssak <andreymyssak@gmail.com> Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
SergeyMyssak
force-pushed
the
3336-Fix-bottom-notification-bar-width
branch
from
fd09fb1
to
25a26fd
Compare
|
Closing this in favour of #3978 |
Description
Fix the width of the bottom notification bar.
It is not possible to override the width without
!importantbecause theOuiBottomBarcomponent uses inline styles. We have the option of not using!importantin our styles, but then we would have to remove the default inline styles in theOuiBottomBarcomponent so we have more flexibility with the styles.Screen.Recording.2023-04-07.at.16.54.12.mov
Issues Resolved
#3336
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr